Re: A failure in t/038_save_logical_slots_shutdown.pl - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: A failure in t/038_save_logical_slots_shutdown.pl
Date
Msg-id CAA4eK1L76fo8JcSCGjDqTarsH7NNkYG8dm9vC-XEBdx8u3WgnA@mail.gmail.com
Whole thread Raw
In response to Re: A failure in t/038_save_logical_slots_shutdown.pl  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: A failure in t/038_save_logical_slots_shutdown.pl
List pgsql-hackers
On Thu, Jan 25, 2024 at 5:07 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Thu, Jan 25, 2024 at 4:27 PM Bharath Rupireddy
> <bharath.rupireddyforpostgres@gmail.com> wrote:
> >
> > Thanks. I'll wait a while and then add it to CF to not lose it in the wild.
> >
>
> Feel free to add it to CF. However, I do plan to look at it in the
> next few days.
>

The patch looks mostly good to me. I have changed the comments and
commit message in the attached. I am planning to push this tomorrow
unless you or others have any comments on it.

--
With Regards,
Amit Kapila.

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Introduce XID age and inactive timeout based replication slot invalidation
Next
From: "adjkldd@126.com"
Date:
Subject: confusing `case when` column name