Re: Report bytes and transactions actually sent downtream - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Report bytes and transactions actually sent downtream
Date
Msg-id CAA4eK1L5DE_hqYQK+2RPk86HtLjbtVUiJvobUsDF8panQ4oQEg@mail.gmail.com
Whole thread
In response to Re: Report bytes and transactions actually sent downtream  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Fri, Mar 13, 2026 at 7:39 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Mar 12, 2026 at 06:13:33PM +0530, Ashutosh Sharma wrote:
> > Could you please share your thoughts on this? Your inputs would help
> > us determine the next steps - whether we should proceed with renaming,
> > and if so, what names you would suggest, or whether we should leave
> > things as they are.
>
> FWIW, I still find the use of _wal_ in these fields rather confusing,
> and they add more inconsistencies with the internal structures of
> reorderbuffer.c.  The goal is to add a field to track the number of
> bytes sent downstream.  Hence, I would suggest to give up on the
> rename, add the new field, perhaps consider improving the docs for the
> existing fields to tell to which context these numbers refer to, then
> call it a day.
>

+1.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Streamify more code paths
Next
From: Etsuro Fujita
Date:
Subject: Re: Import Statistics in postgres_fdw before resorting to sampling.