Re: [HACKERS] GatherMerge misses to push target list - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [HACKERS] GatherMerge misses to push target list
Date
Msg-id CAA4eK1KuA2Cg963BdSyOK=+XnkU47B3P_VfgdZWxNWwBOce60A@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] GatherMerge misses to push target list  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] GatherMerge misses to push target list  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Sat, Nov 11, 2017 at 5:05 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Mon, Sep 18, 2017 at 7:02 AM, Rushabh Lathia
> <rushabh.lathia@gmail.com> wrote:
>>> In that case, can you please mark the patch [1] as ready for committer in
>>> CF app
>>
>> Done.
>
> I think this patch is mostly correct, but I think the change to
> planner.c isn't quite right.  ordered_rel->reltarget is just a dummy
> target list that produces nothing.  Instead, I think we should pass
> path->pathtarget, representing the idea that whatever Gather Merge
> produces as output is the same as what you put into it.
>

Agreed.  Your change looks good to me.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: [HACKERS] possible encoding issues with libxml2 functions
Next
From: Amit Kapila
Date:
Subject: Re: [HACKERS] A GUC to prevent leader processes from running subplans?