Request a Demo
Home   >   mailing lists

Re: Adding a range check on the sequence index from the publisher. - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Adding a range check on the sequence index from the publisher.
Date
Msg-id CAA4eK1KTHhnVG=0z58f7968ksNW4dD3WyUi3755k6HH27ookcA@mail.gmail.com
Whole thread
In response to Adding a range check on the sequence index from the publisher.  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: Adding a range check on the sequence index from the publisher.
List pgsql-hackers
Tree view 
On Tue, Sep 22, 2026 at 1:22 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> I've attached the patch to fix it. Feedback is very welcome.
>

Thanks, fix LGTM. BTW, on similar lines, we can change seqRow[0] to
INT4OID from INT8OID in copy_sequences()[1]. Since
libpqrcv_processTuples uses the declared type's input function, the
value is parsed by int8in and then silently truncated to its low 32
bits. This can be risky too.

[1]:
Oid seqRow[REMOTE_SEQ_COL_COUNT] = {INT8OID,

--
With Regards,
Amit Kapila.

pgsql-hackers by date:

Previous
From: "ZizhuanLiu X-MAN"
Date:
Subject: Re: Optimize MCV stats for sortable types and utilize sorted-order properties
Next
From: solai v
Date:
Subject: Re: Prevent object capture in CREATE/ALTER EXTENSION scripts