On Wed, Nov 17, 2021 at 7:12 PM osumi.takamichi@fujitsu.com
<osumi.takamichi@fujitsu.com> wrote:
>
> On Wednesday, November 17, 2021 10:00 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > Can you please tell us why you think the names in your proposed patch are
> > better than the existing names proposed in Sawada-San's patch? Is it because
> > those fields always contain the information of the last or latest error that
> > occurred in the corresponding subscription worker?
> This is one reason.
>
> Another big reason comes from the final alignment when we list up all columns of both patches.
> The patches in this thread is trying to introduce a column that indicates
> cumulative count of error to show all error counts that the worker got in the past.
>
Okay, I see your point and it makes sense to rename columns after
these other stats. I am not able to come up with any better names than
what is being used here. Sawada-San, do you agree with this, or do let
us know if you have any better ideas?
BTW, I think the way you are computing error_count in
pgstat_recv_subworker_error() doesn't seem correct to me because it
will accumulate the counter/bytes for the same error again and again.
You might want to update these counters after we have checked that the
received error is not the same as the previous one.
--
With Regards,
Amit Kapila.
