Re: Include schema-qualified names in publication error messages. - Mailing list pgsql-hackers

On Thu, May 7, 2026 at 5:50 PM Euler Taveira <euler@eulerto.com> wrote:
>
> On Thu, May 7, 2026, at 7:07 AM, Amit Kapila wrote:
> >
> > That makes sense. I have changed that in the attached and made slight
> > modifications in the comments. How about attached?
> >
>
> One minor suggestion is to rename get_relation_qualified_name to
> get_qualified_relation_name. If we want to reuse this new function
> get_relation_qualified_name into other places, shouldn't we move this function
> to lsyscache.c? There are places like matview.c that could benefit from this new
> function.
>

This suggestion sounds reasonable to me but I suggest instead moving
this new function to rel.h as an inline function or into relcache.c as
those are the places where we take functions with Relation as input.
Additionally, we can name the function as
RelationGetQualifiedRelationName().

--
With Regards,
Amit Kapila.