Re: [BUG] Unexpected action when publishing partition tables - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [BUG] Unexpected action when publishing partition tables
Date
Msg-id CAA4eK1KDV2uOA6R6MTLUhzuy9bnXdam5gUTnD68vQCdVn8XUfQ@mail.gmail.com
Whole thread Raw
In response to RE: [BUG] Unexpected action when publishing partition tables  ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>)
Responses Re: [BUG] Unexpected action when publishing partition tables
Re: [BUG] Unexpected action when publishing partition tables
List pgsql-hackers
On Fri, Sep 17, 2021 at 11:36 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> On Thursday, September 16, 2021 6:05 PM Amit Kapila <amit.kapila16@gmail.com>
> > > On Tuesday, September 14, 2021 10:41 PM vignesh C <vignesh21@gmail.com> wrote:
> > > > On Tue, Sep 7, 2021 at 11:38 AM houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com> wrote:
> > >
> > > Thanks for the comment.
> > > Attach new version patches which clean the table at the end.
> > >
> >
> > + * For partitioned table contained in the publication, we must
> > + * invalidate all partitions contained in the respective partition
> > + * trees, not just the one explicitly mentioned in the publication.
> >
> > Can we slightly change the above comment as: "For the partitioned tables, we
> > must invalidate all partitions contained in the respective partition hierarchies,
> > not just the one explicitly mentioned in the publication. This is required
> > because we implicitly publish the child tables when the parent table is
> > published."
> >
> > Apart from this, the patch looks good to me.
> >
> > I think we need to back-patch this till v13. What do you think?
>
> I agreed.
>
> Attach patches for back-branch, each has passed regression tests and pgindent.
>

Thanks, your patches look good to me. I'll push them sometime next
week after Tuesday unless there are any comments.

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Logical replication timeout problem
Next
From: Daniel Gustafsson
Date:
Subject: Re: proposal: possibility to read dumped table's name from file