Re: Doc: CREATE_REPLICATION_SLOT command requires the plugin name - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Doc: CREATE_REPLICATION_SLOT command requires the plugin name
Date
Msg-id CAA4eK1KBEyN6eEEe2zDjjNYtCk5HAz0P-eM9HCe-Wmi5AXXx5A@mail.gmail.com
Whole thread Raw
In response to Doc: CREATE_REPLICATION_SLOT command requires the plugin name  (Antonin Houska <ah@cybertec.at>)
Responses Re: Doc: CREATE_REPLICATION_SLOT command requires the plugin name  (Antonin Houska <ah@cybertec.at>)
List pgsql-hackers
On Tue, Feb 1, 2022 at 3:44 PM Antonin Houska <ah@cybertec.at> wrote:
>
> I got a syntax error when using the command according to the existing
> documentation. The output_plugin parameter needs to be passed too.
>

Why do we need it for physical slots? The syntax in repl_gram.y is as follows:
/* CREATE_REPLICATION_SLOT slot TEMPORARY PHYSICAL [options] */
K_CREATE_REPLICATION_SLOT IDENT opt_temporary K_PHYSICAL create_slot_options
...
/* CREATE_REPLICATION_SLOT slot TEMPORARY LOGICAL plugin [options] */
| K_CREATE_REPLICATION_SLOT IDENT opt_temporary K_LOGICAL IDENT
create_slot_options

The logical slots do need output_plugin but not physical ones.

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: row filtering for logical replication
Next
From: Antonin Houska
Date:
Subject: Re: Doc: CREATE_REPLICATION_SLOT command requires the plugin name