Re: pgsql: Fix the display of iso-8859-1 message type in apply worker. - Mailing list pgsql-committers

From Amit Kapila
Subject Re: pgsql: Fix the display of iso-8859-1 message type in apply worker.
Date
Msg-id CAA4eK1K4Ttte5scwj0uu5boJyU3dfNeBQc1okMtGE0_zwQp-Yw@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Fix the display of iso-8859-1 message type in apply worker.  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers
On Tue, Jul 25, 2023 at 10:51 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Jul 25, 2023 at 03:52:32AM +0000, Amit Kapila wrote:
> > Fix the display of UNKNOWN message type in apply worker.
> >
> > We include the message type while displaying an error context in the
> > apply worker. Now, while retrieving the message type string if the
> > message type is unknown we throw an error that will hide the original
> > error. So, instead, we need to simply return the string indicating an
> > unknown message type.
>
> koel is complaining after this commit:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-07-25%2004%3A49%3A03
>

Pushed a fix.

--
With Regards,
Amit Kapila.



pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Fix code indentation vioaltion introduced in commit d38ad8e31d.
Next
From: Michael Paquier
Date:
Subject: pgsql: Document more assumptions of LWLock variable changes with WAL in