Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
Date
Msg-id CAA4eK1K0aGmwQarFB=exVd576DLdCyALaKY70oAFn77B1j5a3A@mail.gmail.com
Whole thread Raw
In response to Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description  (shveta malik <shveta.malik@gmail.com>)
Responses Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
List pgsql-hackers
On Mon, Sep 2, 2024 at 9:14 AM shveta malik <shveta.malik@gmail.com> wrote:
>
> On Mon, Sep 2, 2024 at 5:47 AM Peter Smith <smithpb2250@gmail.com> wrote:
> > ----
> >
> > To summarize, the current description wrongly describes the field as a
> > time duration:
> > "The time since the slot has become inactive."
> >
> > I suggest replacing it with:
> > "The slot has been inactive since this time."
> >
>
> +1 for the change. If I had read the document without knowing about
> the patch, I too would have interpreted it as a duration.
>

The suggested change looks good to me as well. I'll wait for a day or
two before pushing to see if anyone thinks otherwise.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Bertrand Drouvot
Date:
Subject: Re: Add callback in pgstats for backend initialization
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Use XLOG_CONTROL_FILE macro everywhere?