Re: Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION
Date
Msg-id CAA4eK1JzWLpmAGcJ4W6MnE5GEj8BWjbiQEWJGSAT2=HW47wZ9Q@mail.gmail.com
Whole thread Raw
In response to Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION  ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>)
List pgsql-hackers
On Mon, Oct 17, 2022 at 8:39 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> While working on some logical replication related features.
> I found the HINT message could be improved when I tried to add a publication to
> a subscription which was disabled.
>
> alter subscription sub add publication pub2;
> --
> ERROR: ALTER SUBSCRIPTION with refresh is not allowed for disabled subscriptions
> HINT: Use ALTER SUBSCRIPTION ... SET PUBLICATION ... WITH (refresh = false).
> --
>
> Because I was executing the ADD PUBLICATION command, I feel the hint should
> also mention it instead of SET PUBLICATION.
>

+1. I haven't tested it yet but the changes look sane.

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: PATCH: Using BRIN indexes for sorted output
Next
From: Amit Kapila
Date:
Subject: Re: Improve description of XLOG_RUNNING_XACTS