Re: [HACKERS] Broken hint bits (freeze) - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [HACKERS] Broken hint bits (freeze)
Date
Msg-id CAA4eK1JxV1+UTyU3T2WM6rhiDEZy6zk3cx+Y3TaXCXAwQxcU1Q@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Broken hint bits (freeze)  (Sergey Burladyan <eshkinkot@gmail.com>)
Responses Re: [HACKERS] Broken hint bits (freeze)  (Sergey Burladyan <eshkinkot@gmail.com>)
Re: [HACKERS] Broken hint bits (freeze)  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Tue, Jun 20, 2017 at 7:05 PM, Sergey Burladyan <eshkinkot@gmail.com> wrote:
> Amit Kapila <amit.kapila16@gmail.com> writes:
>
>> On Tue, Jun 20, 2017 at 3:40 PM, Sergey Burladyan <eshkinkot@gmail.com> wrote:
> I use pg 9.2 and "skipping restartpoint, already performed at" is from
> src/backend/access/transam/xlog.c:8643
> after this statement it return from CreateRestartPoint() and do not run
>    8687     CheckPointGuts(lastCheckPoint.redo, flags);
>

You are right, so it will skip restartpoint in such a case.

>> >> > Uh, as I understand it the rsync is going to copy the missing WAL file
>> >> > from the new master to the standby, right, and I think pg_controldata
>> >> > too, so it should be fine.  Have you tested to see if it fails?
>> >
>> > It need old WAL files from old version for correct restore heap
>> > files. New WAL files from new version does not have this information.
>> >
>>
>> So in such a case can we run rsync once before pg_upgrade?
>
> I just copy last WAL from stopped old master into running old standby
> before it shutdown and wait till it replayed. After that standby can
> issue restartpoint at the same location as in stopped master.
>

Hmm.  I think we need something that works with lesser effort because
not all users will be as knowledgeable as you are, so if they make any
mistakes in copying the file manually, it can lead to problems.  How
about issuing a notification (XLogArchiveNotifySeg) in shutdown
checkpoint if archiving is enabled?

> I am not sure about rsync, in my production server I have for example
> 111 GB in pg_xlog and if I run rsync for pg_xlog it must send ~ 40GB
> of new WALs I think.
>

Isn't the difference between old and new is just the last WAL segment
file?  What is the source of this difference?


-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] Regarding Postgres Dynamic Shared Memory (DSA)
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Something is rotten in publication drop