Re: Fix WITHOUT OVERLAPS multirange with location replication - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Fix WITHOUT OVERLAPS multirange with location replication
Date
Msg-id CAA4eK1JsKoZfdjFBC=tgX-YyyxaFKGjfzbXXCKqr1N7BXvFmTw@mail.gmail.com
Whole thread
In response to Re: Fix WITHOUT OVERLAPS multirange with location replication  (Paul A Jungwirth <pj@illuminatedcomputing.com>)
List pgsql-hackers
On Fri, Oct 9, 2026 at 4:55 PM Paul A Jungwirth
<pj@illuminatedcomputing.com> wrote:
>
> On Fri, Oct 9, 2026, Nisha Moond <nisha.moond412@gmail.com> wrote:
> >
>
> > 1) The change to RelationFindDeletedTupleInfoByIndex() doesn't seem to
> > be covered by a test. Maybe we could add a case to 035_conflicts.pl?
>
> This was tricky, but I figured out a way to do it. My test adds a row
> on the publisher before creating the subscription, then uses
> copy_data=false. Then I add & delete a "decoy" row with a different
> multirange but the same lossy bounding range. When the publisher
> updates the first row, it gets update_deleted before the fix and
> update_missing after.
>

I think this test is timing dependent because if Delete happens before
Update, the conflict slot could be updated and the row could be
removed. If it is too tricky/tough to write this test, we can even
skip it.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Buffer pin leak in hash index bucket splits
Next
From: Amit Kapila
Date:
Subject: Re: Fix WITHOUT OVERLAPS multirange with location replication