Request a Demo
Home   >   mailing lists

Re: Reject negative max_retention_duration values - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Reject negative max_retention_duration values
Date
Msg-id CAA4eK1Jop+GW0JHRfyg+enDYLQJP1JX9c3eu1yP7RdFN=e3=NA@mail.gmail.com
Whole thread
List pgsql-hackers
Tree view 
On Tue, Jun 9, 2026 at 1:35 PM Chao Li <li.evan.chao@gmail.com> wrote:
>
 ```
>
> It only checks !MySubscription->maxretention, so a negative value will pass. Then, in TimestampDifferenceExceeds, the
negativevalue is counted, causing the actual wait time to be shorter than the intended value. 
>

Thanks for the report and analysis. On first read, it sounds correct
to me, I'll spend some more time and share my feedback.

--
With Regards,
Amit Kapila.

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: PG19 FK fast path: OOB write and missed FK checks during batched
Next
From: Marcos Pegoraro
Date:
Subject: Re: Get rid of "Section.N.N.N" on DOCs