Re: Fix comment in report_sequence_errors() - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Fix comment in report_sequence_errors()
Date
Msg-id CAA4eK1Jh-=rzmV6us_YwT1eqEunO9jD6yYFeaZP+2Fs0Kbr71Q@mail.gmail.com
Whole thread
In response to Re: Fix comment in report_sequence_errors()  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Mon, Jun 8, 2026 at 5:58 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Sun, Jun 07, 2026 at 07:35:05PM +0500, Imran Zaheer wrote:
> > However, the actual warning message emitted and the logic that
> > populates missing_seqs_idx both refer to sequences that are missing on
> > the publisher side, not the subscriber.
> >
> > The fix is to replace "subscriber" with "publisher" in that comment line.
>
> The first comment could also make clear the fact that we care about
> inconsistent definitions on the subscriber side.  Grabbed these,
> thanks.
>

The patch looks good to me. IIUC, you are planning to commit this one
along with some other typo/minor fixes, right?

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Ashutosh Sharma
Date:
Subject: Re: synchronized_standby_slots behavior inconsistent with quorum-based synchronous replication
Next
From: Nisha Moond
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication