Re: Thinko/typo in ExecSimpleRelationInsert - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Thinko/typo in ExecSimpleRelationInsert
Date
Msg-id CAA4eK1JgRb9+gk0s7E54KwGEtv0j=DRKzPUjDSX+SKekEiLT7g@mail.gmail.com
Whole thread Raw
In response to Re: Thinko/typo in ExecSimpleRelationInsert  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
List pgsql-hackers
On Wed, Jun 27, 2018 at 11:30 AM, Ashutosh Bapat
<ashutosh.bapat@enterprisedb.com> wrote:
> On Wed, Jun 27, 2018 at 11:24 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>>>
>>> I don't understand what do you mean by consistent. Do you mean to say
>>> that current usage " Store the slot into tuple ... " is correct?
>>>
>>
>> Oh no,  I was talking about replacing it with below comment which is
>> used at other places in the code.
>> /*
>> * get the heap tuple out of the tuple table slot, making sure we have a
>> * writable copy
>> */
>
> Probably yes. But I would just correct the usage and grammar.
>

Okay, pushed!

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Few cosmetic suggestions for commit 16828d5c (Fast Alter TableAdd Column...)
Next
From: Haribabu Kommi
Date:
Subject: Re: Does logical replication supports cross platform servers?