Re: Skipping schema changes in publication - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Skipping schema changes in publication
Date
Msg-id CAA4eK1JfPVXh1rVQV1Y_YoaX52hEi0OVxyT2_HKfKcKd55pR0w@mail.gmail.com
Whole thread
In response to Re: Skipping schema changes in publication  (Peter Smith <smithpb2250@gmail.com>)
List pgsql-hackers
On Wed, Mar 18, 2026 at 1:35 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> ======
> src/test/regress/expected/publication.out
>
> 1.
> +-- fail - SET ALL TABLES on a publication requires superuser privileges
> +ALTER PUBLICATION testpub5 SET ALL TABLES EXCEPT TABLE (testpub_tbl1); -- fail
> +ERROR:  must be superuser to alter FOR ALL TABLES publication
> +ALTER PUBLICATION testpub5 SET ALL TABLES; -- fail
> +ERROR:  must be superuser to alter FOR ALL TABLES publication
> +SET ROLE regress_publication_user;
> +DROP PUBLICATION testpub4, testpub5;
>
> The error messages don't quite seem correct. e.g. You are not trying
> "to alter FOR ALL TABLES publication". You are trying to alter a
> publication to convert it to a  "FOR ALL TABLES" publication.
>

I also find this error message not conveying the proper information. I
suggest changing it to: "must be superuser to set ALL TABLES" and
"must be superuser to set ALL SEQUENCES" for all tables, sequences
cases respectively.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Supporting non-deterministic collations with tailoring rules.
Next
From: Michael Paquier
Date:
Subject: Re: Adding locks statistics