Re: logicalrep_message_type throws an error - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: logicalrep_message_type throws an error
Date
Msg-id CAA4eK1JatUtoE-hNx9cP3WfD+kWPDASfM9xjZoJfM78Y42sMZQ@mail.gmail.com
Whole thread Raw
In response to Re: logicalrep_message_type throws an error  ("Euler Taveira" <euler@eulerto.com>)
List pgsql-hackers
On Sat, Jul 15, 2023 at 7:16 PM Euler Taveira <euler@eulerto.com> wrote:
>
> On Sat, Jul 15, 2023, at 4:27 AM, Amit Kapila wrote:
>
> Do you have something like attached in mind?
>
>
> WFM. I would change the comment that says
>
> This function is called to provide context in the error ...
>
> to
>
> This message provides context in the error ...
>
> because this comment is not at the beginning of the function but *before* the
> message.
>

Sounds reasonable to me. I'll make this modification before pushing
unless there are more comments/suggestions.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Zhang Mingli
Date:
Subject: Re: Improve heapgetpage() performance, overhead from serializable
Next
From: Justin Pryzby
Date:
Subject: Re: ALTER TABLE SET ACCESS METHOD on partitioned tables