Request a Demo
Home   >   mailing lists

Re: [Patch] add new parameter to pg_replication_origin_session_setup - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [Patch] add new parameter to pg_replication_origin_session_setup
Date
Msg-id CAA4eK1JWM_GxnDn8T0+B3+dEqzACkUj7rvfy_B_ukq5myvqxGg@mail.gmail.com
Whole thread
In response to Re: [Patch] add new parameter to pg_replication_origin_session_setup  (shveta malik <shveta.malik@gmail.com>)
Responses Re: [Patch] add new parameter to pg_replication_origin_session_setup
List pgsql-hackers
Tree view 
On Wed, Feb 11, 2026 at 5:09 PM shveta malik <shveta.malik@gmail.com> wrote:
>
> On Wed, Feb 11, 2026 at 3:41 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> >
> > I see your point but one advantage with the proposed code change is
> > that it started to appear that we can extend this part of code easily
> > in the future as it separates most of the handling related to when a
> > user has given acquired_by parameter's value as zero and non-zero.
>
> Okay, yes. So I am okay with it. The slight change I suggested (if to
> else-if) and a comment will make it more clean.
>

I have tried to address both your suggestions in the attached. See, if
this looks okay to you now?

--
With Regards,
Amit Kapila.
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Remove unused at_sharedrel from autovac_table
Next
From: Peter Eisentraut
Date:
Subject: Re: SQL Property Graph Queries (SQL/PGQ)