Re: PostgreSQL in Windows console and Ctrl-C - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: PostgreSQL in Windows console and Ctrl-C
Date
Msg-id CAA4eK1JV4uhFKBpJWuyLN9anY4DNkkes=LtUwCZXcC0MC+6FZA@mail.gmail.com
Whole thread Raw
In response to Re: PostgreSQL in Windows console and Ctrl-C  (Christian Ullrich <chris@chrullrich.net>)
Responses Re: PostgreSQL in Windows console and Ctrl-C
List pgsql-hackers
On Sat, Apr 12, 2014 at 12:36 PM, Christian Ullrich
<chris@chrullrich.net> wrote:
> * From: Amit Kapila
>
>> Another thing to decide about this fix is that whether it is okay to fix
>> it for CTRL+C and leave the problem open for CTRL+BREAK?
>> (The current option used (CREATE_NEW_PROCESS_GROUP) will handle only
>> CTRL+C).
>
> Below is a new (right now very much proof-of-concept) patch to replace
> my earlier one. It has the same effect on Ctrl-C the change to pg_ctl had,
> and additionally ignores Ctrl-Break as well.

This fix won't allow CTRL+C for other cases like when server is started
directly with postgres binary.
./postgres -D <data_dir_path>
I think this doesn't come under your original complaint and as such I
don't see any problem in allowing CTRL+C for above case.

One another way could be to use CREATE_NEW_CONSOLE instead of
CREATE_NEW_PROCESS_GROUP in you previous fix, but I am not
sure if it's acceptable to users to have a new console window for server.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: WIP patch (v2) for updatable security barrier views
Next
From: David Rowley
Date:
Subject: Patch to fix a couple of compiler warnings from 80a5cf64