Re: How can end users know the cause of LR slot sync delays? - Mailing list pgsql-hackers

On Fri, Nov 21, 2025 at 11:00 AM shveta malik <shveta.malik@gmail.com> wrote:
>
> A few comments on 001:
>
> 1)
> +        slots, but may (if leftover from a promotedstandby) contain a
> timestamp.
> promotedstandby --> promoted standby
>
> 2)
> +            s.slotsync_skip_count,
> +            s.last_slotsync_skip_at,
>
> Shall we rename last_slotsync_skip_at to slotsync_last_skip_at. That
> way all slotsync related stats columns will have same prefix.
>

Sounds reasonable especially when the doc explains that this is the
time at which last slot synchronization was skipped.

BTW, can we split the patch into two? First for slot sync skip stats,
and the second one for SlotSyncSkipReason? It would be easier to
review and commit that way.

--
With Regards,
Amit Kapila.