Request a Demo
Home   >   mailing lists

Re: [Patch] add new parameter to pg_replication_origin_session_setup - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [Patch] add new parameter to pg_replication_origin_session_setup
Date
Msg-id CAA4eK1JJHvaUNfxHqOXLQ7ERwDQT2iKT9wU8B1RYT7gmjtZD-g@mail.gmail.com
Whole thread
In response to Re: [Patch] add new parameter to pg_replication_origin_session_setup  (shveta malik <shveta.malik@gmail.com>)
List pgsql-hackers
Tree view 
On Wed, Mar 25, 2026 at 3:03 PM shveta malik <shveta.malik@gmail.com> wrote:
>
> On Wed, Mar 25, 2026 at 1:51 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Wed, Feb 11, 2026 at 5:09 PM shveta malik <shveta.malik@gmail.com> wrote:
> > >
> > > On Wed, Feb 11, 2026 at 3:41 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > >
> > > >
> > > > I see your point but one advantage with the proposed code change is
> > > > that it started to appear that we can extend this part of code easily
> > > > in the future as it separates most of the handling related to when a
> > > > user has given acquired_by parameter's value as zero and non-zero.
> > >
> > > Okay, yes. So I am okay with it. The slight change I suggested (if to
> > > else-if) and a comment will make it more clean.
> > >
> >
> > I have tried to address both your suggestions in the attached. See, if
> > this looks okay to you now?
> >
>
> LGTM now, thanks!
>

Pushed.

--
With Regards,
Amit Kapila.

pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: synchronized_standby_slots behavior inconsistent with quorum-based synchronous replication
Next
From: Michael Paquier
Date:
Subject: Re: Adding locks statistics