Re: Distinguish publication exclusions in object addresses - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Distinguish publication exclusions in object addresses
Date
Msg-id CAA4eK1JCYqWPDVfrqD01Ug6vow2S7BgXXVTkrc25N8s91NTudw@mail.gmail.com
Whole thread
In response to Re: Distinguish publication exclusions in object addresses  (Manuel Reyes Bravo <manuelreyesbravo@gmail.com>)
Responses Re: Distinguish publication exclusions in object addresses
List pgsql-hackers
On Thu, Sep 17, 2026 at 7:53 PM Manuel Reyes Bravo
<manuelreyesbravo@gmail.com> wrote:
>
> vignesh C <vignesh21@gmail.com> wrote:
> > That seems better, here is an updated v3 version to handle the same.
> > Same patch applies on pg19 branch and tests passes in both the
> > branches.
>
> v3 no longer has the temporary table test that v2 added, I assume because
> the pg_temp_N number depends on the backend.  stats_ext.sql already deals
> with that by redacting the number, and the attached top-up does the same,
> so the case stays covered:
>
>     NOTICE:  cannot specify relation
> "pg_temp_REDACTED.testpub_temptbl" in the publication EXCEPT clause
> (This operation is not supported for temporary tables.)
>
> It passes on both branches, and the same block run from three sessions
> at once, with temp schemas pg_temp_1, pg_temp_2 and pg_temp_3, prints the
> same line in each.
>

Thanks for sharing the testcase patch but I don't find compelling to
add it along with current patch due to: (a) it is not necessary to use
temp table to test this patch, (b) I am not sure we want to test all
negative cases especially with some special handling though I am open
to consider it separately as a test to increase code-coverage.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Henson Choi
Date:
Subject: Re: Row pattern recognition
Next
From: shihao zhong
Date:
Subject: Re: Python/pytest test framework take two