Re: Remove unused function parameters, part 2: replication - Mailing list pgsql-hackers

On Fri, Nov 28, 2025 at 2:54 PM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> RetainDeadTuplesData *rdt_data in can_advance_nonremovable_xid(): 228c37086855
> RetainDeadTuplesData *rdt_data in resume_conflict_info_retention(): 0d48d393d465
>

All nearby static functions introduced for the same feature have
passed this RetainDeadTuplesData structure. At this point, it is not
used but it can be used in future. So, I'm not sure if it is a good
idea to remove it now. Added Hou-San to see if he has any opinion on
this.

> StringInfo s in apply_handle_origin(): 665d1fad99e7
>

All apply_handle_* functions passed the same parameter and that
function has some TODO as well, so again not sure if it is a good idea
to remove it.

--
With Regards,
Amit Kapila.