Re: [DOC] Update ALTER SUBSCRIPTION documentation - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [DOC] Update ALTER SUBSCRIPTION documentation
Date
Msg-id CAA4eK1J11phiaoCOmsjNqPZ9BOWyLXYrfgrm5vU2uCFPF2kN1Q@mail.gmail.com
Whole thread Raw
In response to [DOC] Update ALTER SUBSCRIPTION documentation  (Robert Sjöblom <robert.sjoblom@fortnox.se>)
Responses Re: [DOC] Update ALTER SUBSCRIPTION documentation
List pgsql-hackers
On Fri, May 5, 2023 at 6:47 PM Robert Sjöblom <robert.sjoblom@fortnox.se> wrote:
>
> We have recently used the PostgreSQL documentation when setting up our
> logical replication. We noticed there was a step missing in the
> documentation on how to drop a logical replication subscription with a
> replication slot attached.
>
> We clarify the documentation to include prerequisites for running the
> DROP SUBSCRIPTION command. Please see attached patch.
>

Shouldn't we also change the following errhint in the code as well?
ReportSlotConnectionError()
{
...
ereport(ERROR,
(errcode(ERRCODE_CONNECTION_FAILURE),
errmsg("could not connect to publisher when attempting to drop
replication slot \"%s\": %s",
slotname, err),
/* translator: %s is an SQL ALTER command */
errhint("Use %s to disassociate the subscription from the slot.",
"ALTER SUBSCRIPTION ... SET (slot_name = NONE)")));
...
}

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: "盏一"
Date:
Subject: Re: Proposal for Prototype Implementation to Enhance C/C++ Interoperability in PostgreSQL
Next
From: Masahiko Sawada
Date:
Subject: Re: Perform streaming logical transactions by background workers and parallel apply