Re: PHJ file leak. - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: PHJ file leak.
Date
Msg-id CAA4eK1J+e4OfBYVUTF-DdbsWUjYWMbn1yy_mtgihXoTaWPN_Hw@mail.gmail.com
Whole thread Raw
In response to Re: PHJ file leak.  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: PHJ file leak.  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
On Wed, Nov 13, 2019 at 6:13 AM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
>
> At Wed, 13 Nov 2019 09:48:19 +1300, Thomas Munro <thomas.munro@gmail.com> wrote in
> >
> > Here's the version I'd like to commit in a day or two, once the dust
> > has settled on the minor release.  Instead of adding yet another copy
> > of that code, I just moved it out of the loop; this way there is no
> > way to miss it.  I think the comment could also be better, but I'll
> > wait for the concurrent discussions about the meaning of
> > ExecShutdownNode() to fix that in master.
>
> The phatch's shape looks better. Thanks.
>

+1.  LGTM as well.


-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Coding in WalSndWaitForWal
Next
From: Amit Kapila
Date:
Subject: Re: [HACKERS] Block level parallel vacuum