Request a Demo
Home   >   mailing lists

Re: [PATCH] Fix Int32GetDatum used for bool column in CREATE SUBSCRIPTION - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [PATCH] Fix Int32GetDatum used for bool column in CREATE SUBSCRIPTION
Date
Msg-id CAA4eK1+m1j6Rahj+cB7acxL5hgHVAYTX2kCfPk_YZbywaPNgDg@mail.gmail.com
Whole thread
In response to Re: [PATCH] Fix Int32GetDatum used for bool column in CREATE SUBSCRIPTION  (Nisha Moond <nisha.moond412@gmail.com>)
List pgsql-hackers
Tree view 
On Mon, Apr 27, 2026 at 1:59 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
>
> On Mon, Apr 27, 2026 at 11:03 AM Lakshmi N <lakshmin.jhs@gmail.com> wrote:
> >
> > Hi hackers,
> >
> > In CreateSubscription(), the subretentionactive catalog column (declared as
> > bool in pg_subscription.h) is populated using Int32GetDatum() instead of
> > BoolGetDatum():
> >
> > This writes 4 bytes into a 1-byte bool Datum. It is inconsistent with the
> > ALTER SUBSCRIPTION path which correctly uses BoolGetDatum().
> >
> > The attached patch fixes this to use BoolGetDatum(), matching both the
> > catalog definition and the ALTER path.
> >
>
> +1
> This looks like an oversight in commit a850be2.
>

Pushed.

--
With Regards,
Amit Kapila.

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Remove inner joins based on foreign keys
Next
From: Amit Kapila
Date:
Subject: Re: [Patch]: Fix excessive ProcArrayLock acquisitions with subscription max_retention_duration=0