Re: Notify downstream to discard the streamed transaction which was aborted due to crash. - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Notify downstream to discard the streamed transaction which was aborted due to crash.
Date
Msg-id CAA4eK1+KPcfP9fhtNoqjWyxW6X+4A49Ku2XQr_=6KZCsbRxJOQ@mail.gmail.com
Whole thread Raw
In response to Notify downstream to discard the streamed transaction which was aborted due to crash.  ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>)
Responses RE: Notify downstream to discard the streamed transaction which was aborted due to crash.
List pgsql-hackers
On Fri, Jan 6, 2023 at 9:25 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
>
> To fix it, One idea is to send a stream abort message when we are cleaning up
> crashed transaction on publisher(e.g. in ReorderBufferAbortOld()). And here is
> a tiny patch which changes the same. I have confirmed that the bug is fixed and
> all regression tests pass. I didn't add a testcase because we need to make sure
> the crash happens before all the WAL logged transactions data are decoded which
> doesn't seem easy to write a stable test for this.
>

Your fix looks good to me. Have you tried this in PG-14 where it was introduced?

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
Next
From: vignesh C
Date:
Subject: Re: Logical replication - schema change not invalidating the relation cache