Re: Logical Replication of sequences - Mailing list pgsql-hackers

On Tue, Oct 14, 2025 at 5:08 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> On Tue, Oct 14, 2025 at 3:36 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> 0001 and 0002 looks good,
>

Thanks, I pushed 0001. I feel it is better to next commit refactoring
patch v20251014-0003-Reorganize-tablesync-Code-and-Introduce-sy as
that would be less controversial. What do you think?

> except this duplicate version checking code below in fetch_relation_list [1][2], I mean check_relkind and sequence
fetchingboth are related changes and start from version 19, so we can do a single check.  Instead of the
'check_relkind'variable name we can change it to 'support_relkind_seq' or something like that and then we can use this
inboth checks. 
>

Sounds reasonable to me.

--
With Regards,
Amit Kapila.