Re: [PATCH] Fix typo in pgstat_replslot.c - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [PATCH] Fix typo in pgstat_replslot.c
Date
Msg-id CAA4eK1+2fiQ+S1m4dGygTeY82LPWSQXxag3-q=UncoVbCfOF=A@mail.gmail.com
Whole thread Raw
In response to [PATCH] Fix typo in pgstat_replslot.c  ("zengman" <zengman@halodbtech.com>)
Responses Re: [PATCH] Fix typo in pgstat_replslot.c
List pgsql-hackers
On Wed, Jan 7, 2026 at 4:52 PM zengman <zengman@halodbtech.com> wrote:
>
> I noticed this could be corrected to `exists` (instead of `exits`) here, same as commit
63ed3bc7f9a66035e0b741aaa542de35a90fe1cc.
> ```c
>         /* Check if the slot exits with the given name. */
>         slot = SearchNamedReplicationSlot(name, false);
>
>         if (!slot)
>                 ereport(ERROR,
>                                 (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
>                                  errmsg("replication slot \"%s\" does not exist",
>                                                 name)));
> ```
>

oops, we should have caught it last time along with commit
63ed3bc7f9a66035e0b741aaa542de35a90fe1cc but anyway I checked there is
no more similar typo in the code. So, the patch LGTM.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Newly created replication slot may be invalidated by checkpoint
Next
From: Amit Kapila
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication