Request a Demo
Home   >   mailing lists

Re: Use strtoi64() in pgbench, replacing its open-coded implementation - Mailing list pgsql-hackers

From Neil Chen
Subject Re: Use strtoi64() in pgbench, replacing its open-coded implementation
Date
Msg-id CAA3qoJnvD7Av5gTkPF++isGU2xcjdq5M5ndR0xcFwR96Ro0b1g@mail.gmail.com
Whole thread Raw
In response to Use strtoi64() in pgbench, replacing its open-coded implementation  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Use strtoi64() in pgbench, replacing its open-coded implementation
List pgsql-hackers
Tree view
Hi,

On Thu, Nov 20, 2025 at 8:57 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
Here's a small patch to replace the int64 parsing code in pgbench with a
call to strtoi64(). Makes it a little simpler.


+1 on this simplification – it definitely makes the code cleaner.
One small note: the updated code doesn’t handle trailing spaces in the input string. Should we consider this a concern? 

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis
Next
From: Tom Lane
Date:
Subject: Re: PRI?64 vs Visual Studio (2022)