Re: [PATCH] Align verify_heapam.c error message offset with test expectations - Mailing list pgsql-hackers

From Neil Chen
Subject Re: [PATCH] Align verify_heapam.c error message offset with test expectations
Date
Msg-id CAA3qoJkdMFcVN+G9uvYtY6LM=92vyiMK9Z351TBpOoKhQM2=CA@mail.gmail.com
Whole thread Raw
In response to [PATCH] Align verify_heapam.c error message offset with test expectations  ("zengman" <zengman@halodbtech.com>)
Responses Re: [PATCH] Align verify_heapam.c error message offset with test expectations
List pgsql-hackers
Hi zengman,

On Wed, Jan 21, 2026 at 10:37 PM zengman <zengman@halodbtech.com> wrote:

This indicates that for the test case at offnum == 36, the error message should report "offset 43" (the successor), not "offset 36" (the current tuple).
However, when I updated the test expectation from \d+ wildcard to the exact value offset 43, the test fails.
This makes me wonder whether the current code in verify_heapam.c (lines 777, 793, 799) should be using nextoffnum instead of ctx.offnum.


Fully agreed.
I think there's no need to modify the expectations. Seems the 0002 patch alone is sufficient.

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Remove no-op pull_var_clause flag
Next
From: Tom Lane
Date:
Subject: Re: file_fdw: Support multi-line HEADER option.