Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Add Commit/Rollback toolbar action - Mailing list pgadmin-hackers

From Sanket Mehta
Subject Re: [PATCH] Add Commit/Rollback toolbar action
Date
Msg-id CA+yw=mOmxMxxWDwKgzf7yQNz5ZLmVm25HiqKTHR-Z6iX6CnXcA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add Commit/Rollback toolbar action  (Sanket Mehta <sanket.mehta@enterprisedb.com>)
Responses Re: [PATCH] Add Commit/Rollback toolbar action
List pgadmin-hackers
Tree view
Hi John,

I have applied the patch and below are my suggestions:

1. Rollback and commit icons should be disabled session is not in transaction mode
2. Rollback and Commit should also be included in Query menu and individual short cut should be assigned to them.

Dave,

Can we have any other icons for both the functionality as these icons looks odd to me.



Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Tue, Jun 16, 2015 at 5:03 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Sure Dave.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Tue, Jun 16, 2015 at 4:55 PM, Dave Page <dpage@pgadmin.org> wrote:
Sanket, can you look at this please?

Sent from my iPad

> On 15 Jun 2015, at 16:33, John Obaterspok <john.obaterspok@gmail.com> wrote:
>
> Hello,
>
> With the newly added option to disable auto commit (hurray) I really missed commit/rollback toolbar buttons. Attached patch adds this.
>
> -- john
>
> <0001-Add-Commit-Rollback-toolbar-action.patch>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers


pgadmin-hackers by date:

Previous
From: Sanket Mehta
Date:
Subject: Re: [PATCH] Add Commit/Rollback toolbar action
Next
From: John Obaterspok
Date:
Subject: Re: [PATCH] Add Commit/Rollback toolbar action