Re: Please add timestamps to pgagent log - Mailing list pgadmin-support

From Sanket Mehta
Subject Re: Please add timestamps to pgagent log
Date
Msg-id CA+yw=mOZR8PbayYM_aL5uuva9GxOPeUMnsYToRZ3gZ-dz8pOpw@mail.gmail.com
Whole thread Raw
In response to Re: Please add timestamps to pgagent log  (Dave Page <dpage@pgadmin.org>)
Responses Re: Please add timestamps to pgagent log
List pgadmin-support
Hi Dave,


On Thu, Jul 16, 2015 at 5:56 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Jul 16, 2015 at 8:19 AM, Sanket Mehta
<sanket.mehta@enterprisedb.com> wrote:
> Hi Dave,
>
> I have created a new patch with changes you have suggested.
> Please find it attached with this mail.
>
> Please do review it.

Doesn't the following break the schema version check in pgAgent.cpp?
 
 ADD_DEFINITIONS(-DPGAGENT_VERSION_MAJOR=${CPACK_PACKAGE_VERSION_MAJOR})
+ADD_DEFINITIONS(-DPGAGENT_VERSION="${VERSION}")

No Dave it does not breaking the schema version check in pgAgent.cpp.
I have tested it.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-support by date:

Previous
From: Dave Page
Date:
Subject: Re: Please add timestamps to pgagent log
Next
From: Dave Page
Date:
Subject: Re: Please add timestamps to pgagent log