Re: Feature: psql - display current search_path in prompt - Mailing list pgsql-hackers

From Florents Tselai
Subject Re: Feature: psql - display current search_path in prompt
Date
Msg-id CA+v5N40zVNkm_+rsT_+zAk6mjVye-8-Vn4YDzuBCe0M7vBp9Eg@mail.gmail.com
Whole thread Raw
In response to Re: Feature: psql - display current search_path in prompt  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: Feature: psql - display current search_path in prompt
List pgsql-hackers



On Fri, Oct 24, 2025 at 5:20 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
On Fri, Oct 24, 2025 at 05:10:13PM +0300, Florents Tselai wrote:
> Good catch. v2 attached

Thanks.

+     <varlistentry id="app-psql-prompting-S">
+      <term><literal>%S</literal></term>
+      <listitem><para>The current search path.</para></listitem>
+     </varlistentry>

I'd suggest linking to a page about the search_path [0].

Done  

+extern const char *session_search_path(void);

This function appears to be unused.

+                                       /*
+                                        * Distinguish unknown (NULL) from an empty but valid search_path ("").
+                                        * If not connected or older server doesn't report it via ParameterStatus,
+                                        * show "?".
+                                        */
+                                       if (!pset.db || PQparameterStatus(pset.db, "search_path") == NULL)
+                                               strlcpy(buf, "?", sizeof(buf));
+                                       else
+                                               strlcpy(buf, PQparameterStatus(pset.db, "search_path"), sizeof(buf));
+                                       break;

Shouldn't we move most of this logic to session_search_path() and use it
here?

Yes

 

 
Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: C11: should we use char32_t for unicode code points?
Next
From: Akshay Joshi
Date:
Subject: Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statement