Re: Add SQL/JSON ON MISMATCH clause to JSON_VALUE - Mailing list pgsql-hackers

From Florents Tselai
Subject Re: Add SQL/JSON ON MISMATCH clause to JSON_VALUE
Date
Msg-id CA+v5N40MaAQQOxucapnW9kVxyHgt8qVmrt4vxv_2=DRxQ+y+AA@mail.gmail.com
Whole thread Raw
In response to Add SQL/JSON ON MISMATCH clause to JSON_VALUE  (Florents Tselai <florents.tselai@gmail.com>)
Responses Re: Add SQL/JSON ON MISMATCH clause to JSON_VALUE
List pgsql-hackers
 

I've had trouble making JSON_QUERY work too, 
so I suspect that although my tests pass,
there may be something I'm missing in the executor side of things.

"For those curious, I found the issue: in ExecEvalJsonExprPath, I
 had misplaced the check for jsexpr->on_mismatch.  
I wasn't setting jsestate->escontext.details_wanted = true early enough.
 Without this, the soft error context wasn't capturing the specific SQL error code needed to identify the mismatch.

Attaching a v2 that implements ON MISMATCH for JSON_QUERY and JSON_TABLE too.

That said, the semantics of ON ERROR / MISMATCH / EMPTY are complex. 
I expect someone with access to and detailed knowledge of the standard might be able to poke holes in certain edge cases, particularly regarding precedence.

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Time to drop RADIUS support?
Next
From: Michael Paquier
Date:
Subject: Re: Extended Statistics set/restore/clear functions.