Re: addFkRecurseReferencing use unassigned fkconstraint->fk_with_period value - Mailing list pgsql-hackers

From Paul A Jungwirth
Subject Re: addFkRecurseReferencing use unassigned fkconstraint->fk_with_period value
Date
Msg-id CA+renyXVqed2GBrfKQuZd8sgprNE1WnVb2TFHaEFk1YM6ab=_g@mail.gmail.com
Whole thread
In response to Re: addFkRecurseReferencing use unassigned fkconstraint->fk_with_period value  (Haibo Yan <tristan.yim@gmail.com>)
Responses Re: addFkRecurseReferencing use unassigned fkconstraint->fk_with_period value
List pgsql-hackers
On Mon, Sep 28, 2026 at 11:18 PM Haibo Yan <tristan.yim@gmail.com> wrote:
>
 changed the wording to "with pre-existing
> rows" and moved the NOT VALID / NOT ENFORCED tests after the
> pg_get_constraintdef checks.
>
> There are no code changes from v1.

This looks good to me too. Andres reported the VALIDATE CONSTRAINT
case in [0], but it's nice to have fixes to all three cases in one
place.

If you want, here is a v3 with a less verbose commit message. Also I
added the note suggested by Andrew, which seems worth including in
release notes.

[0] https://www.postgresql.org/message-id/sesqxzfcujkcnrwpir5xvhy7iamhsbjiqt6r2xqmb7hqkulte6%40bbuc42qzanzs

Yours,

--
Paul              ~{:-)
pj@illuminatedcomputing.com

Attachment

pgsql-hackers by date:

Previous
From: shihao zhong
Date:
Subject: Re: pg_resetwal: add --cluster-state option
Next
From: Michael Paquier
Date:
Subject: Re: Use WALReadFromBuffers in more places