Re: Inconsistent trigger behavior between two temporal leftovers - Mailing list pgsql-hackers

From Paul A Jungwirth
Subject Re: Inconsistent trigger behavior between two temporal leftovers
Date
Msg-id CA+renyWRW2XUoqXL7-WOEeTh2gW4dsTQMACR1fGNRFJTmsggBw@mail.gmail.com
Whole thread
In response to Re: Inconsistent trigger behavior between two temporal leftovers  (Zsolt Parragi <zsolt.parragi@percona.com>)
List pgsql-hackers
On Tue, May 5, 2026 at 2:16 PM Zsolt Parragi <zsolt.parragi@percona.com> wrote:
>
> + /*
> + * Re-copy the original row into leftoverSlot because
> + * ExecInsert may pass leftoverSlot to BEFORE INSERT
> + * triggers, which can modify the slot contents.
> + */
>
> Shouldn't this mention BEFORE ROW INSERT triggers? Everywhere else the
> comments/commit message/test is specific about this.

I agree being specific is helpful. Here is an updated patch.

Yours,

--
Paul              ~{:-)
pj@illuminatedcomputing.com

Attachment

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: pgindent versus struct members and typedefs
Next
From: Paul A Jungwirth
Date:
Subject: Re: FOR PORTION OF does not recompute GENERATED STORED columns that depend on the range column