Re: Fix GetOperatorFromCompareType - Mailing list pgsql-hackers

From Paul A Jungwirth
Subject Re: Fix GetOperatorFromCompareType
Date
Msg-id CA+renyW0NUF47D7k1Z0VVuASwNTAZpvW89fEoLVOFkZOFTiNnQ@mail.gmail.com
Whole thread Raw
In response to Re: Fix GetOperatorFromCompareType  (Neil Chen <carpenter.nail.cz@gmail.com>)
List pgsql-hackers
On Sun, Nov 16, 2025 at 11:18 PM Neil Chen <carpenter.nail.cz@gmail.com> wrote:
> After your patch changes, the line '*opid = InvalidOid;' seems removable.
>
> Also, if the second validation check of opclass after 'get_opclass_method' feels a bit odd, moving
'get_opclass_opfamily_and_input_type'to the very top would work -- purely for visual clarity. :) 

Thanks for the review! Here is a patch with your suggestions incorporated.

Yours,

--
Paul              ~{:-)
pj@illuminatedcomputing.com

Attachment

pgsql-hackers by date:

Previous
From: Sami Imseih
Date:
Subject: Re: another autovacuum scheduling thread
Next
From: Bertrand Drouvot
Date:
Subject: Re: Add os_page_num to pg_buffercache