Re: [PATCH] Fix null pointer dereference in PG19 - Mailing list pgsql-hackers

From Paul A Jungwirth
Subject Re: [PATCH] Fix null pointer dereference in PG19
Date
Msg-id CA+renyUkKaWtWZX2UcojKVjM=f1F5kgdvR8Pr5QqyJqqe_dw-g@mail.gmail.com
Whole thread
Responses Re: [PATCH] Fix null pointer dereference in PG19
List pgsql-hackers
On Thu, Jul 2, 2026 at 12:25 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>
> > But I don't mind holding it back if that's what people want to do.
> > Looking more closely at INSTEAD OF triggers, I found another bug: the
> > FOR PORTION OF qual (and TLE) were not added, so the trigger would
> > fire on more rows than it should, and NEW.valid_at was not
> > pre-computed. The second patch here fixes that. I'll defer to others
> > whether we should fix the INSTEAD OF interaction now or wait 'til v20.
>
> It seems to me that both FOR PORTION OF and INSTEAD OF triggers are SQL
> standard features, so this discussion should refer to what the standard
> says, and possibly consider what other implementations do (in addition
> to discussing what makes sense).  Since that hasn't been done yet, maybe
> prohibiting this combination for now, as proposed by Aleksander, would
> be best.

Okay, let's do that. I'll do some research to see what the standard
says and whether any other RDBMS offers guidance.

Yours,

--
Paul              ~{:-)
pj@illuminatedcomputing.com



pgsql-hackers by date:

Previous
From: Paul A Jungwirth
Date:
Subject: Re: FOR PORTION OF should reject GENERATED columns
Next
From: Kirill Reshke
Date:
Subject: Re: DROP INVALID INDEXES command