Re: json(b)_to_tsvector with numeric values - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: json(b)_to_tsvector with numeric values
Date
Msg-id CA+q6zcVpRdy-UL2TVm05H-aSNy8hHLULO8Db=9VTj_=MPjt3wg@mail.gmail.com
Whole thread Raw
In response to Re: json(b)_to_tsvector with numeric values  (Arthur Zakirov <a.zakirov@postgrespro.ru>)
Responses Re: json(b)_to_tsvector with numeric values  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-hackers
> On 2 April 2018 at 11:27, Arthur Zakirov <a.zakirov@postgrespro.ru> wrote:
> On Mon, Apr 02, 2018 at 11:41:12AM +0300, Oleg Bartunov wrote:
>> On Mon, Apr 2, 2018 at 9:45 AM, Arthur Zakirov <a.zakirov@postgrespro.ru> wrote:
>> I found this bug, when working on presentation about FTS and it looked
>> annoying, since it validates
>> the consistency of FTS.I think this is a bug, which needs to be fixed,
>> else inconsistency with existing full text search  will be gets
>> deeper.
>>
>> The fix looks trivial, but needs a review, of course.
>
> Oh, I understood. The code looks good, tests passed. But maybe it is
> better to use NumericGetDatum() instead of PointerGetDatum()?

Well, technically speaking they're the same, but yes, NumericGetDatum would be
more precise. I've modified it in the attached patch.

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [HACKERS] Add support for tuple routing to foreign partitions
Next
From: Ashutosh Bapat
Date:
Subject: Re: Diagonal storage model