Re: ArchiveEntry optional arguments refactoring - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: ArchiveEntry optional arguments refactoring
Date
Msg-id CA+q6zcUbpK_a1WvUf+wMt0DUXDar29CwXD2MY9DxbHbX_p3hDA@mail.gmail.com
Whole thread Raw
In response to Re: ArchiveEntry optional arguments refactoring  (Chapman Flack <chap@anastigmatix.net>)
Responses Re: ArchiveEntry optional arguments refactoring  (Daniel Gustafsson <daniel@yesql.se>)
Re: ArchiveEntry optional arguments refactoring  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Here is another version, where I accumulated all the suggestions:

* Use NULL as a default value where it was an empty string before (this
  required few minor changes for some part of the code outside ArchiveEntry)

* Rename defn, descr to createStmt, description

* Use a macro to avoid pgindent errors

About the last one. I'm also inclined to use the simpler version of
ARCHIVE_OPTS macro, mostly because the difference between "optional" and
"positional" arguments in the alternative proposal is not that visible. So

> mixing struct arguments and normal function arguments seems
> quite confusing

could probably affect not only readability, but also would be bit more
problematic for updating this code (which was the goal in the first place).

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: using expression syntax for partition bounds
Next
From: Amit Langote
Date:
Subject: Re: problems with foreign keys on partitioned tables