Re: Confused static assertion implementation - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Confused static assertion implementation
Date
Msg-id CA+hUKGLiHAPdQOqEAAWGZ0XNmPcdLrykUWsiADdDx+Fj0xGtww@mail.gmail.com
Whole thread Raw
In response to Re: Confused static assertion implementation  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
On Fri, Nov 14, 2025 at 6:18 PM Chao Li <li.evan.chao@gmail.com> wrote:
> As you added a semi-colon in the line, the one after the empty line can be deleted, though C allows empty statement,
butunnecessary, and may lead to confusion for code readers. 

> You missed to replace this pgac_cv__static_assert with the new name.

Ugh, yeah, the configure change was hopeless.  It looked like it
worked in configure's stdout, which I mistook for success and posted
too soon, sorry about that.  I have fixed those points and verified
that pg_config.h actually has the expected value.

Thanks for the review!

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Drop unnamed portal immediately after execution to completion
Next
From: Masahiko Sawada
Date:
Subject: Re: Issue with logical replication slot during switchover