Re: Mingw task for Cirrus CI - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Mingw task for Cirrus CI
Date
Msg-id CA+hUKGLZo7jbn8P-K9Cp5Dw5rYEMzJxEEOQJvH+X80wMb1UY2Q@mail.gmail.com
Whole thread Raw
In response to Re: Mingw task for Cirrus CI  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: Mingw task for Cirrus CI
List pgsql-hackers
I noticed that this says:

[01:01:45.657] sqlda.pgc: In function 'dump_sqlda':
[01:01:45.657] sqlda.pgc:45:33: warning: format '%d' expects argument
of type 'int', but argument 3 has type 'long long int' [-Wformat=]
[01:01:45.657] 45 | "name sqlda descriptor: '%s' value %I64d\n",
[01:01:45.657] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[01:01:45.657] ......
[01:01:45.657] 49 | sqlda->sqlvar[i].sqlname.data, *(long long int
*)sqlda->sqlvar[i].sqldata);
[01:01:45.657] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[01:01:45.657] | |
[01:01:45.657] | long long int

... but fairywren doesn't.  Why would they disagree on recognising %I64d?

The other warning I'm seeing is present on both, so it's not really
relevant to this thread, just mentioning it...  seems kinda like a
worlds-colliding-problem without an elegant fix (POSIX says you have
to declare it yourself exactly like that, but Windows says linkage
ain't going to work the way you want unless you sprinkle the right
linkage dust on it...), so maybe we just want to put #if
!defined(something something mings) around it and to MinGW's header's
declaration...

[00:48:08.925] c:/cirrus/src/backend/postmaster/postmaster.c: In
function 'PostmasterMain':
[00:48:08.925] c:/cirrus/src/backend/postmaster/postmaster.c:973:31:
warning: '__p__environ' redeclared without dllimport attribute:
previous dllimport ignored [-Wattributes]
[00:48:08.925] 973 | extern char **environ;
[00:48:08.925] | ^~~~~~~



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Cleaning up historical portability baggage
Next
From: Julien Rouhaud
Date:
Subject: Re: [PATCH] postgresql.conf.sample comment alignment.