Re: Drop type "smgr"? - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Drop type "smgr"?
Date
Msg-id CA+hUKGL6dTxXxg1jBPY+YmJbceDxCxcjO33CVYpJuZiX8wAzng@mail.gmail.com
Whole thread Raw
In response to Drop type "smgr"?  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
On Thu, Feb 28, 2019 at 7:02 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> The type smgr has only one value 'magnetic disk'.  ~15 years ago it
> also had a value 'main memory', and in Berkeley POSTGRES 4.2 there was
> a third value 'sony jukebox'.  Back then, all tables had an associated
> block storage manager, and it was recorded as an attribute relsmgr of
> pg_class (or pg_relation as it was known further back).  This was the
> type of that attribute, removed by Bruce in 3fa2bb31 (1997).
>
> Nothing seems to break if you remove it (except for some tests using
> it in an incidental way).  See attached.

Pushed.

Thanks all for the interesting discussion.  I'm trying out Anton
Shyrabokau's suggestion of stealing bits from the fork number.  More
on that soon.

-- 
Thomas Munro
https://enterprisedb.com


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pg_dump is broken for partition tablespaces
Next
From: Noah Misch
Date:
Subject: Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid