Re: Default setting for enable_hashagg_disk - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Default setting for enable_hashagg_disk
Date
Msg-id CA+hUKGKTeLS+q6rbbH=LMgEN9jJG425_6ow+_-fQ1gjOcO6tyg@mail.gmail.com
Whole thread Raw
In response to Re: Default setting for enable_hashagg_disk  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sun, Jul 12, 2020 at 2:27 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> David Rowley <dgrowleyml@gmail.com> writes:
> > hmm yeah. It's unfortunate, but I'm not sure how I'd have implemented
> > it differently.  The problem is made worse by the fact that we'll only
> > release the memory for the hash table during ExecEndHashJoin(). If the
> > planner had some ability to provide the executor with knowledge that
> > the node would never be rescanned, then the executor could release the
> > memory for the hash table after the join is complete.
>
> EXEC_FLAG_REWIND seems to fit the bill already?

FWIW I have a patch that does exactly that, which I was planning to
submit for CF2 along with some other patches that estimate and measure
peak executor memory usage.



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Default setting for enable_hashagg_disk
Next
From: "David G. Johnston"
Date:
Subject: Re: Default setting for enable_hashagg_disk