Re: DSA failed to allocate memory - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: DSA failed to allocate memory
Date
Msg-id CA+hUKGKMsNg55OqAWy-p8+T+bf1UK2CeLgyG0jFtTVnaaEh0qw@mail.gmail.com
Whole thread Raw
In response to Re: DSA failed to allocate memory  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: DSA failed to allocate memory
List pgsql-hackers
On Mon, Feb 20, 2023 at 5:52 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> I'm wondering about this bit in rebin_segment():
>
> +       if (segment_map->header == NULL)
> +               return;
>
> Why would we be rebinning an uninitialised/unused segment?

Answering my own question: because destroy_superblock() can do that.
So I think destroy_superblock() should test for that case, not
rebin_segment().  See attached.

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Fix a typo in md.c
Next
From: Thomas Munro
Date:
Subject: Re: Inconsistent results with libc sorting on Windows