Re: Cleaning up historical portability baggage - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Cleaning up historical portability baggage
Date
Msg-id CA+hUKGK=f5H6wdHyvhU0o3gXjn7Yg8QOpUe69H114Mb=4nJTbQ@mail.gmail.com
Whole thread Raw
In response to Re: Cleaning up historical portability baggage  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Sat, Aug 6, 2022 at 12:03 PM Andres Freund <andres@anarazel.de> wrote:
> HAVE_GETTIMEOFDAY currently is only defined for mingw as the configure test is
> gated to windows - that's somewhat weird imo. mingw has had it since at least
> 2007.  The attached patch makes the gettimeofday() fallback specific to msvc.

+1

> I've renamed the file to win32gettimeofday now. I wonder if we should rename
> files that are specific to msvc to indicate that? But that's for later.

+1, I was thinking the same.

> 1-arg gettimeofday() hasn't been around in a *long* while from what I can
> see. So I've removed that configure test.

+1

LGTM.



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Remaining case where reltuples can become distorted across multiple VACUUM operations
Next
From: Tom Lane
Date:
Subject: Re: Cleaning up historical portability baggage