Postgres Pro
Downloads
Home   >   mailing lists

Re: An out-of-date comment in nodeIndexonlyscan.c - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: An out-of-date comment in nodeIndexonlyscan.c
Date
Msg-id CA+hUKGJomqEBnY_-c6Uk=ogWFipiML=+nEB3CALB4zM+OKm4zQ@mail.gmail.com
Whole thread Raw
In response to Re: An out-of-date comment in nodeIndexonlyscan.c  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: An out-of-date comment in nodeIndexonlyscan.c  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
Tree view 
On Mon, Jun 14, 2021 at 12:54 AM David Rowley <dgrowleyml@gmail.com> wrote:
> I think a more optimal and nicer way of doing that would be setting
> bits in a Bitmapset then checking bms_num_members is equal to
> n_scan_keys.

Shouldn't it be compared with indnkeyatts?  Yes, much nicer, thanks!
Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Continuing instability in insert-conflict-specconflict test
Next
From: Tom Lane
Date:
Subject: Re: Continuing instability in insert-conflict-specconflict test