Re: Asynchronous Append on postgres_fdw nodes. - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Asynchronous Append on postgres_fdw nodes.
Date
Msg-id CA+hUKGJ9vxx-XbrEikpGCqV_R5uXhn_0QEXUk+BX0q7H-LsW0g@mail.gmail.com
Whole thread Raw
In response to Re: Asynchronous Append on postgres_fdw nodes.  (Etsuro Fujita <etsuro.fujita@gmail.com>)
Responses Re: Asynchronous Append on postgres_fdw nodes.  (Etsuro Fujita <etsuro.fujita@gmail.com>)
List pgsql-hackers
On Thu, Jul 2, 2020 at 3:20 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> On Thu, Jul 2, 2020 at 11:14 AM Kyotaro Horiguchi
> <horikyota.ntt@gmail.com> wrote:
> > As the result of a discussion with Fujita-san off-list, I'm going to
> > hold off development until he decides whether mine or Thomas' is
> > better.
>
> I'd like to join the party, but IIUC, we don't yet reach a consensus
> on which one is the right way to go.  So I think we need to discuss
> that first.

Either way, we definitely need patch 0001.  One comment:

-CreateWaitEventSet(MemoryContext context, int nevents)
+CreateWaitEventSet(MemoryContext context, ResourceOwner res, int nevents)

I wonder if it's better to have it receive ResourceOwner like that, or
to have it capture CurrentResourceOwner.  I think the latter is more
common in existing code.



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: security_context_t marked as deprecated in libselinux 3.1
Next
From: Thomas Munro
Date:
Subject: Re: Collation versioning